emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] /srv/bzr/emacs/trunk r104642: * src/process.c (Fset_pr


From: Deniz Dogan
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r104642: * src/process.c (Fset_process_buffer): Clarify return value in docstring.
Date: Tue, 21 Jun 2011 18:00:13 +0200
User-agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.17) Gecko/20110414 Thunderbird/3.1.10

On 2011-06-20 16:26, Stefan Monnier wrote:
-       doc: /* Set buffer associated with PROCESS to BUFFER (a buffer, or 
nil).  */)
+       doc: /* Set buffer associated with PROCESS to BUFFER (a buffer, or nil).
+Return BUFFER.  */)

Actually, I generally prefer not to document the accidental return value
of side-effecting functions.  It's poor style anyway to use that return
value, in my book.


I don't mind at all should you revert the change, I just figured it could be useful for others to know.

For what it's worth, here's the code where I use the return value (not in GNU Emacs):

(defun dirc-setup-server-buffer (process)
  "Set up the server buffer for PROCESS."
  (let ((buffer (set-process-buffer
                 process
                 (pop-to-buffer-same-window
                  (dirc-make-process-buffer-name process)))))
    (with-current-buffer buffer
      (set (make-local-variable 'dirc-buffer-type) 'server)
      (set (make-local-variable 'dirc-process process)))))

/Deniz



reply via email to

[Prev in Thread] Current Thread [Next in Thread]