[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH updated] Support for filesystem watching (inotify)
From: |
Ted Zlatanov |
Subject: |
Re: [PATCH updated] Support for filesystem watching (inotify) |
Date: |
Fri, 24 Jun 2011 07:18:44 -0500 |
User-agent: |
Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) |
On Fri, 24 Jun 2011 05:19:20 -0500 Ted Zlatanov <address@hidden> wrote:
TZ> You have several symbols like Qmodify, and I wanted to suggest that you
TZ> could use a name prefix like for example gnutls.c:
TZ> and that you assign a numeric value directly to the symbol when it's
TZ> initialized instead of statically doing case statements in your
TZ> code.
I noticed you were using the DEFSYM macro, I didn't know about it. I
put it into gnutls.c.
#+begin_src c
DEFSYM(Qgnutls_e_interrupted, "gnutls-e-interrupted");
Fput (Qgnutls_e_interrupted, Qgnutls_code,
make_number (GNUTLS_E_INTERRUPTED));
#+end_src
...and I wanted to mention how I put a numeric value in the symbol's
property list instead of setting it as the value. HTH.
Ted
- Re: [PATCH updated] Support for filesystem watching (inotify), (continued)
- Re: [PATCH updated] Support for filesystem watching (inotify), Stefan Monnier, 2011/06/06
- Re: [PATCH updated] Support for filesystem watching (inotify), Rüdiger Sonderfeld, 2011/06/06
- Re: [PATCH updated] Support for filesystem watching (inotify), Stefan Monnier, 2011/06/06
- Re: [PATCH updated] Support for filesystem watching (inotify), Ted Zlatanov, 2011/06/06
- Re: [PATCH updated] Support for filesystem watching (inotify), Stefan Monnier, 2011/06/07
- Re: [PATCH updated] Support for filesystem watching (inotify), Ted Zlatanov, 2011/06/07
- Re: [PATCH updated] Support for filesystem watching (inotify), Stefan Monnier, 2011/06/07
- Re: [PATCH updated] Support for filesystem watching (inotify), Ted Zlatanov, 2011/06/07
- Re: [PATCH updated] Support for filesystem watching (inotify), Rüdiger Sonderfeld, 2011/06/23
- Re: [PATCH updated] Support for filesystem watching (inotify), Ted Zlatanov, 2011/06/24
- Re: [PATCH updated] Support for filesystem watching (inotify),
Ted Zlatanov <=
- Re: [PATCH updated] Support for filesystem watching (inotify), Stefan Monnier, 2011/06/06
- Re: [PATCH updated] Support for filesystem watching (inotify), Rüdiger Sonderfeld, 2011/06/06