emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: it->nglyphs for automatic compositions


From: Eli Zaretskii
Subject: Re: it->nglyphs for automatic compositions
Date: Tue, 23 Aug 2011 10:07:04 +0300

> From: Kenichi Handa <address@hidden>
> Cc: address@hidden
> Date: Tue, 23 Aug 2011 09:35:59 +0900
> 
> In article <address@hidden>, Eli Zaretskii <address@hidden> writes:
> 
> > Currently, x_produce_glyphs does not set the it->nglyphs member to
> > anything, so it stays at zero.  This causes pos-visible-in-window-p to
> > return incorrect pixel coordinates when invoked on a character that is
> > at column zero and is a composed character.  Note that
> > produce_composite_glyph, which is called only on terminal frames, does
> > set that field.  So I propose the following patch.
> 
> I agree with that patch.  Perhaps I just forgot to set
> it->nglyphs when I added this part of the code:
> 
>   else if (it->what == IT_COMPOSITION)
>     {
>       /* A dynamic (automatic) composition.  */
> [...]
>     }

Thanks, committed.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]