Re: [PATCH 4/4] Fix emacsclient to work with cygw32

[Daniel Colascione]

On 12/29/11 8:28 AM, Juanma Barranquero wrote:
> On Thu, Dec 29, 2011 at 15:03, Daniel Colascione <address@hidden> wrote:
> 
>> -                 ;; On Windows, emacsclient always asks for a tty frame.
>> -                 ;; If running a GUI server, force the frame type to GUI.
>> -                 (when (eq window-system 'w32)
>> +                 ;; On Windows, emacsclient always asks for a tty
>> +                 ;; frame.  If running a GUI server, force the frame
>> +                 ;; type to GUI.  (Cygwin is perfectly happy with
>> +                 ;; multi-tty support, so don't override the user's
>> +                 ;; choice there.)
>> +                 (when (and (eq system-type 'windows-nt)
>> +                            (eq window-system 'w32))


This hunk narrows the scope of a windows-nt special case so that it
doesn't apply to Cygwin.

> Don't you need to fix also this?
> 
>       ;; Delete the client's tty, except on Windows (both GUI and console),
>       ;; where there's only one terminal and does not make sense to delete it.
>       (unless (eq system-type 'windows-nt)
>       (let ((terminal (process-get proc 'terminal)))
>         ;; Only delete the terminal if it is non-nil.
>         (when (and terminal (eq (terminal-live-p terminal) t))
>           (delete-terminal terminal))))
> 
>     Juanma
> 

No --- a Cygwin tty acts like a tty on any other unix, so we don't want
to treat it specially.  The comment refers to native Windows consoles only.

signature.asc
Description: OpenPGP digital signature