[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/4] Refactor window-system configuration
From: |
Daniel Colascione |
Subject: |
Re: [PATCH 2/4] Refactor window-system configuration |
Date: |
Fri, 30 Dec 2011 01:45:36 -0800 |
User-agent: |
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:8.0) Gecko/20111105 Thunderbird/8.0 |
On 12/30/11 1:38 AM, Eli Zaretskii wrote:
>> Date: Fri, 30 Dec 2011 00:26:45 -0800
>> From: Daniel Colascione <address@hidden>
>> On the other hand, using a fixed "dispatch header" --- i.e., one that
>> contains a bunch of preprocessor branches and include directives ---
>> forces us to create yet another place that has to know about all
>> possible window systems.
>
> I see nothing particularly complex about this, FWIW.
The header decision tree would be more logic that doesn't have to be
there. It would amount to yet another moving part in the configuration
machine. Sure, putting this decision tree in one place is better than
pasting it into every C file that does something with a frame (the
current approach), but getting rid of it altogether would be even better.
I honestly don't understand why you're opposed to the include-a-macro
approach, or what you find unclear about it.
> We have our
> share of such ifdefs already
And we should try to centralize these things and make sure we have as
few as possible. They make code hard to follow, especially when nested.
signature.asc
Description: OpenPGP digital signature
- Re: [PATCH 2/4] Refactor window-system configuration, (continued)
- Re: [PATCH 2/4] Refactor window-system configuration, Dan Nicolaescu, 2011/12/29
- Re: [PATCH 2/4] Refactor window-system configuration, Daniel Colascione, 2011/12/29
- Re: [PATCH 2/4] Refactor window-system configuration, Dan Nicolaescu, 2011/12/29
- Re: [PATCH 2/4] Refactor window-system configuration, Daniel Colascione, 2011/12/29
- Re: [PATCH 2/4] Refactor window-system configuration, Eli Zaretskii, 2011/12/30
- Re: [PATCH 2/4] Refactor window-system configuration, Daniel Colascione, 2011/12/30
- Re: [PATCH 2/4] Refactor window-system configuration, Eli Zaretskii, 2011/12/30
- Re: [PATCH 2/4] Refactor window-system configuration, Eli Zaretskii, 2011/12/30
- Re: [PATCH 2/4] Refactor window-system configuration, Daniel Colascione, 2011/12/30
- Re: [PATCH 2/4] Refactor window-system configuration, Eli Zaretskii, 2011/12/30
- Re: [PATCH 2/4] Refactor window-system configuration,
Daniel Colascione <=
- Re: [PATCH 2/4] Refactor window-system configuration, Stefan Monnier, 2011/12/31
- Re: [PATCH 2/4] Refactor window-system configuration, Stefan Monnier, 2011/12/30
- Re: [PATCH 2/4] Refactor window-system configuration, Eli Zaretskii, 2011/12/30
[PATCH 3/4] Implement cygw32, Daniel Colascione, 2011/12/29
- Re: [PATCH 3/4] Implement cygw32, Eli Zaretskii, 2011/12/29
- Re: [PATCH 3/4] Implement cygw32, Daniel Colascione, 2011/12/29
- Re: [PATCH 3/4] Implement cygw32, Eli Zaretskii, 2011/12/29
- Re: [PATCH 3/4] Implement cygw32, Daniel Colascione, 2011/12/29
- Re: [PATCH 3/4] Implement cygw32, Jason Rumney, 2011/12/29
- Re: [PATCH 3/4] Implement cygw32, Eli Zaretskii, 2011/12/30