Re: Emacs 23.4 release candidate 1

[Kenichi Handa]

In article <address@hidden>, "HIROSHI OOTA" <address@hidden> writes:

> On Fri, 20 Jan 2012 00:53:41 +0900, Chong Yidong <address@hidden> wrote:
> > The release candidate for Emacs 23.4 is now available for download at:
> >
> >   ftp://alpha.gnu.org/gnu/emacs/pretest/emacs-23.4rc1.tar.gz
> >
> > Note that although the version number has been bumped to 23.4 in the
> > tarball and in the emacs-23 branch, I have not tagged the release yet,
> > in case there are last minute changes.
> >
> > If no serious problem surfaces in the next couple of days, I'll release
> > this as Emacs 23.4.  So please help give it as much testing as possible.
> > Thank you.

> the ecoding.c:encode_designation_at_bol  shuld return  EMACS_INT.
> --
> Hiroshi Oota

I agree with the change.  As my computer for Emacs hacking
is begin repaired, it's difficult for me to commit it.
Could someone please do it?

---
Kenichi Handa
address@hidden


> --- src/coding.c      (revision 868)
> +++ src/coding.c      (working copy)

> @@ -944,7 +948,7 @@

>   static unsigned char *alloc_destination P_ ((struct coding_system *,
>                                            EMACS_INT, unsigned char *));
>   static void setup_iso_safe_charsets P_ ((Lisp_Object));
> -static int encode_designation_at_bol P_ ((struct coding_system *,
> +static EMACS_INT encode_designation_at_bol P_ ((struct coding_system *,
>                                         int *, int *, unsigned char *));
>   static int detect_eol P_ ((const unsigned char *,
>                          EMACS_INT, enum coding_category));
> @@ -4509,7 +4513,7 @@

>      If the current block ends before any end-of-line, we may fail to
>      find all the necessary designations.  */

> -static int
> +static EMACS_INT
>   encode_designation_at_bol (coding, charbuf, charbuf_end, dst)
>        struct coding_system *coding;
>        int *charbuf, *charbuf_end;