Re: [Emacs-diffs] /srv/bzr/emacs/trunk r107346: Check FROM arg to substring in icomplete-completions

[Leo]

On 2012-02-23 23:42 +0800, Stefan Monnier wrote:
> Please use Bazaar's "--fixes" argument (or the "Fixes:" header in
> *VC-Log*).  This will work "automatically" in *VC-Log* if you use C-c
> C-a to fill the buffer from the ChangeLog.

Thank you for the tip.

[snipped 12 lines]
> Actually, this is not the right fix: it just papers over another bug.
> The most immediate bug is where we compute prefix-len: the `if' takes
> the first branch (the "fast-path") but the test is not thorough enough
> for your test case and returns an incorrect answer.  I've disabled the
> fast-path (and reverted your patch since it's then unneeded).
>
> But note that cycle-completion still has several other problems when
> combined with icomplete.  Some are plain bugs (working on one of them
> as we speak), and others are mostly design issues "what should ideally
> happen?".

Thanks for fixing it properly.

Leo