Re: Evil defvars in org.el

[Bastien]

Chong Yidong <address@hidden> writes:

> org.el (and org-agenda.el, and maybe others) have defvars like this:
>
> (defvar entry)
> (defvar date)
>
> This is going to blow up in someone's face, because it makes `entry' and
> `date' unusable as lexical variables, even though those are very common
> variable names.  That is to say, loading Org mode would change the
> behavior of packages using lexical binding in some unpredictable way.

Yes, this is bugging me too.

> Why does org need to do this?  

>From latest calendar.el in Emacs:

;; A note on free variables:

;; The calendar passes around a few dynamically bound variables, which
;; unfortunately have rather common names.  They are meant to be
;; available for external functions, so the names can't be changed.

;; displayed-month, displayed-year: bound in calendar-generate, the
;;   central month of the 3 month calendar window
;; original-date, number: bound in diary-list-entries, the arguments
;;   with which that function was called.
;; date, entry: bound in diary-list-sexp-entries (qv)
   ^^^^  ^^^^^

Org uses those two free variables in several places.

> Could you try to clean it up?

I would love too.  Is there anything I can do without messing up with
Calendar's code?

-- 
 Bastien