emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 'struct window' cleanup #4


From: Eli Zaretskii
Subject: Re: 'struct window' cleanup #4
Date: Mon, 02 Jul 2012 20:07:18 +0300

> From: Stefan Monnier <address@hidden>
> Date: Mon, 02 Jul 2012 10:48:08 -0400
> Cc: Emacs development discussions <address@hidden>
> 
> vscroll should be int, as should be the hscroll amounts.
> The vpos probably as well.

I agree, on all 3 counts.  Since the corresponding coordinates in
pixel units (current_x and current_y from 'struct it'), which are
typically about 10 times larger than the above 3, are ints, it doesn't
make sense to have these declared as ptrdiff_t.

Vertical and horizontal screen positions are generally the size of the
Emacs window, i.e. bounded by the display size.  (Some internal Emacs
display routines simulate a larger window for the purposes of
adjusting the displayed area, e.g., while scrolling.  But they never
go too far outside the display dimensions, because doing so makes the
display sluggish, and people complain sooner or later.)  Those values
are a far cry from being anywhere near INT_MAX.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]