[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Inefficiency in Bgotoifnil byte-code instruction
From: |
Stefan Monnier |
Subject: |
Re: Inefficiency in Bgotoifnil byte-code instruction |
Date: |
Tue, 10 Jul 2012 06:31:09 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) |
> How do you feel about this ChangeLog entry?
Looks OK. Nit picks:
> + * bytecode.c (BYTE_CODE_THREADED): New define.
We usually call cpp definitions "macros" rather than "defines".
Also, add a line saying something like "Use indirect threading when
applicable".
> + (BYTE_CODES): New define. Replaces all old byte-code defines.
> + (enum byte_code_op): New.
This one is a new *type*.
> + (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New defines.
> + (exec_byte_code): Use new defines.
And this last one can just be "Use them".
> I wasn't sure if you wanted me to spell out all the Bmumble defines that
> were replaced.
No, that's not necessary.
Stefan
- Re: Inefficiency in Bgotoifnil byte-code instruction, (continued)
- Re: Inefficiency in Bgotoifnil byte-code instruction, Stefan Monnier, 2012/07/03
- Re: Inefficiency in Bgotoifnil byte-code instruction, Tom Tromey, 2012/07/03
- Re: Inefficiency in Bgotoifnil byte-code instruction, Stefan Monnier, 2012/07/03
- Re: Inefficiency in Bgotoifnil byte-code instruction, Tom Tromey, 2012/07/03
- Re: Inefficiency in Bgotoifnil byte-code instruction, Aurélien Aptel, 2012/07/03
- Re: Inefficiency in Bgotoifnil byte-code instruction, Tom Tromey, 2012/07/03
- Re: Inefficiency in Bgotoifnil byte-code instruction, Stefan Monnier, 2012/07/03
- Re: Inefficiency in Bgotoifnil byte-code instruction, Tom Tromey, 2012/07/06
- Re: Inefficiency in Bgotoifnil byte-code instruction, Stefan Monnier, 2012/07/06
- Re: Inefficiency in Bgotoifnil byte-code instruction, Tom Tromey, 2012/07/09
- Re: Inefficiency in Bgotoifnil byte-code instruction,
Stefan Monnier <=
- Re: Inefficiency in Bgotoifnil byte-code instruction, John Wiegley, 2012/07/03
- Re: Inefficiency in Bgotoifnil byte-code instruction, Tom Tromey, 2012/07/06