OSX Build broken (bisect results attached) (was Re: still getting build errors)

[Randal L. Schwartz]

>>>>> "Randal" == Randal L Schwartz <address@hidden> writes:

Randal> And I'm getting build errors in nsterm.m (since two days ago):
Randal> /Users/merlyn/MIRROR/emacs-GIT/src/../lib               -MMD -MF 
deps/nsterm.d -MP     -g -O2  nsterm.m
Randal> nsterm.m: In function 'ns_timeout':
Randal> nsterm.m:422: error: 'timeout' undeclared (first use in this function)
Randal> nsterm.m:422: error: (Each undeclared identifier is reported only once
Randal> nsterm.m:422: error: for each function it appears in.)
Randal> nsterm.m: In function 'ns_get_color':
Randal> nsterm.m:1449: warning: passing argument 2 of 
'__builtin___snprintf_chk' makes integer from pointer without a cast
Randal> nsterm.m:1449: warning: passing argument 5 of 
'__builtin___snprintf_chk' makes pointer from integer without a cast
Randal> make[2]: *** [nsterm.o] Error 1
Randal> make[1]: *** [src] Error 2
Randal> make: *** [bootstrap] Error 2

Here's the commit that broke the build on OSX:


commit a747ace964290726190617148e99ac955ab9a3f2
Author: Paul Eggert <address@hidden>
Date:   Tue Jul 10 16:24:36 2012 -0700

    EMACS_TIME simplification (Bug#11875).
    
    This replaces macros (which typically do not work in GDB)
    with functions, typedefs and enums, making the code easier to debug.
    The functional style also makes code easier to read and maintain.
    * lib-src/profile.c (TV2): Remove no-longer-needed static var.
    * src/systime.h: Include <sys/time.h> on all hosts, not just if
    WINDOWSNT, since 'struct timeval' is needed in general.
    (EMACS_TIME): Now a typedef, not a macro.
    (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
    not macros.
    (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
    (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
    (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
    (EMACS_TIME_LE): Now functions, not macros.
    (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
    (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
    which are not functions.  All uses rewritten to use:
    (make_emacs_time): New function.
    (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
    (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
    not functions.  All uses rewritten to use the following,
    respectively:
    (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
    (add_emacs_time, sub_emacs_time): New functions.
    * src/atimer.c: Don't include <sys/time.h>, as "systime.h" does
    this.
    * src/fileio.c (Fcopy_file):
    * src/xterm.c (XTflash): Get the current time closer to when it's
    used.
    * src/makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.


-- 
Randal L. Schwartz - Stonehenge Consulting Services, Inc. - +1 503 777 0095
<address@hidden> <URL:http://www.stonehenge.com/merlyn/>
Smalltalk/Perl/Unix consulting, Technical writing, Comedy, etc. etc.
See http://methodsandmessages.posterous.com/ for Smalltalk discussion