emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] /srv/bzr/emacs/trunk r109306: Use an include file in c


From: Juanma Barranquero
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r109306: Use an include file in configure.ac's AH_BOTTOM
Date: Tue, 31 Jul 2012 14:10:05 +0200

> revno: 109306
> committer: Glenn Morris <address@hidden>
> branch nick: trunk
> timestamp: Mon 2012-07-30 17:20:43 -0400
> message:
>   Use an include file in configure.ac's AH_BOTTOM

This change brings a little trouble on Windows.

1) The new conf_pos.h unconditionally includes alloca.h, which does
not work on Windows.
2) It unconditionally defines AMPERSAND_FULL_NAME, which again, is
undef on Windows.

To fix 2) it would be enough to #undef it on ms-w32.h, but alas,
post_conf.h is included in config.in / config.nt after
config_opsysfile.

Both problems can be "fixed" by adding suitable #ifdef WINDOWSNT /
#else / #endif to conf_post.h... except that, again, WINDOWSNT is
defined in ms-w32.h, so too late.

I can certainly move the definition of WINDOWSNT to the start of
config.nt, but that adds a difference that I'd like to avoid (and it's
ugly). Would it be possible to move AMPERSAND_FULL_NAME back to
config.in?

As for alloca.h, another possible fix is just to add an empty alloca.h
to nt/sys.

Thoughts?

    Juanma



reply via email to

[Prev in Thread] Current Thread [Next in Thread]