Re: /srv/bzr/emacs/trunk r109456: Separate read and write access to Lisp_Object slots of struct frame.

[Andy Moreton]

On Mon 06 Aug 2012, Dmitry Antipov wrote:

> On 08/06/2012 10:47 AM, Bastien wrote:
>
>> This change completely breaks my Emacs.  To reproduce:
>>
>> emacs -Q
>> C-h v line-spacing RET
>>
>>     => hangs forever, yells weird sounds, etc.
>>
>> line-spacing is just an example here, any variable is fine.
>
> Argh, sorry for breaking the things. Should be fixed in 109463.
>
> Dmitry

Your changes in r109456 also broke the Windows build:

gcc -I. -c -gdwarf-2 -g3  -DEMACSDEBUG -fno-crossjumping  
-IC:/emacs/devel/libxml2-2.7.8/include/libxml2 -IC:/emacs/devel/gnutls-3.0.21/i 
                    nclude -IC:/emacs/devel/giflib-4.1.4-1/include 
-IC:/emacs/devel/jpeg-6b-4/include -IC:/emacs/devel/tiff-3.8.2-1/include 
-IC:/emacs/devel/                     libpng-1.4.3-1/include 
-IC:/emacs/devel/xpm-3.5.1-1/include 
-IC:/emacs/devel/xpm-3.5.1-1/src/xpm/3.5.1/libXpm-3.5.1-src/lib -IC:/emacs/de   
                  vel/zlib-1.2.5-2/include -Demacs=1 -I../lib -I../nt/inc 
-DHAVE_NTGUI=1 -DUSE_CRT_DLL=1 -DPURESIZE=5000000 -o oo/i386/w32term.o w32term.c
w32term.c: In function 'x_frame_rehighlight':
w32term.c:2975:49: error: lvalue required as left operand of assignment
w32term.c: In function 'x_scroll_bar_create':
w32term.c:3647:3: error: lvalue required as left operand of assignment
w32term.c: In function 'w32_condemn_scroll_bars':
w32term.c:3832:33: error: lvalue required as left operand of assignment
w32term.c:3837:43: error: lvalue required as left operand of assignment
w32term.c: In function 'w32_redeem_scroll_bar':
w32term.c:3868:41: error: lvalue required as left operand of assignment
w32term.c:3882:3: error: lvalue required as left operand of assignment
w32term.c: In function 'w32_judge_scroll_bars':
w32term.c:3899:35: error: lvalue required as left operand of assignment


    AndyM