emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 5/9] Prevent crash if w32 used before it's initialized


From: Daniel Colascione
Subject: Re: [PATCH 5/9] Prevent crash if w32 used before it's initialized
Date: Tue, 07 Aug 2012 10:28:08 -0700
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:14.0) Gecko/20120713 Thunderbird/14.0

On 8/7/12 10:23 AM, Eli Zaretskii wrote:
>> Date: Tue, 07 Aug 2012 01:19:27 -0700
>> From: Daniel Colascione <address@hidden>
>>
>> ---
>>  src/w32fns.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/src/w32fns.c b/src/w32fns.c
>> index 8ef4982..9743822 100644
>> --- a/src/w32fns.c
>> +++ b/src/w32fns.c
>> @@ -4833,7 +4833,7 @@ x_display_info_for_name (Lisp_Object name)
>>    CHECK_STRING (name);
>>  
>>    for (dpyinfo = &one_w32_display_info, names = w32_display_name_list;
>> -       dpyinfo;
>> +       dpyinfo && !NILP (w32_display_name_list);
>>         dpyinfo = dpyinfo->next, names = XCDR (names))
>>      {
>>        Lisp_Object tem;
> 
> Is this a real problem with the native w32 build?  If so, can you tell
> how to reproduce it?

No --- it's something that came up in my testing late last year, and
I've forgotten the exact circumstances of the problem now. The change
seems harmless enough though.


Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]