Re: [Emacs-diffs] /srv/bzr/emacs/trunk r109327: Generalize INTERNAL_FIELD between buffers, keyboards and frames.

[Dmitry Antipov]

On 08/08/2012 11:46 AM, Chong Yidong wrote:

> Isn't the point of Coccinelle to make it possible to transform the code
> with minimal manual intervention?

YMMV - now it just refuses to parse the whole xdisp.c :-(.

> With the Coccinelle scripts you've
> written and committed, it shouldn't matter *when* we pull the trigger to
> transform the direct accesses into *VAR macros.

A lot of other pointers should be considered because not all pointers
to collectable objects are represented by Lisp_Objects.

> This will mitigate the
> problem that "new GC tree will look so different so the final merge will
> be a tremendous task".  If the new GC tree starts out with the same code
> transformations, the merge would involve running Coccinelle on the old
> tree, then doing a diff between the result and the GC branch.

Will look at further development of coccinelle; I don't believe that
this is possible just now.

> By the way, would you eventually need a macro for the common Vfoo = bar
> case?

Will see; I started from large objects with complex layout to hit all
possible difficulties at the very beginning.

Dmitry