emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: The rest of xVARs


From: Stefan Monnier
Subject: Re: The rest of xVARs
Date: Fri, 10 Aug 2012 11:18:26 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux)

>>>>> I can't continue without solving (B|K)VARs issue, and X = B->field/
>>>>> BSET(B, field, X) is enough for my purposes;
>>>> You can split the BVAR into a BGET and BSET for now.
>>> OK, the patch is > 200K uncompressed.
>> Here's a simpler solution: split BVAR into BVAR and BSET.  I'm sure the
>> patch will substantially smaller and hence cause much fewer conflicts.
> OK

Looks good, feel free to install.

>> Stefan "tired of resolving cosmetic conflicts with your patches"
> Coccinelle tends to eat spaces and tabs (especially between function
> name and '(' opens an argument list),so I do quite a lot of manual
> adjustments to fit our coding style; but sometimes I can miss the
> poorly formatted entry :-(.

You've done a great job of adjusting it seems, since all the conflicts
I got were always due to real (tho usually cosmetic, such as
introducing/removing FVAR) changes.


        Stefan "hovering between 1MB and 2MB of local changes, many of
                them cosmetic"



reply via email to

[Prev in Thread] Current Thread [Next in Thread]