[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] partial revert of overlays (+patch)
From: |
Stefan Monnier |
Subject: |
Re: [PATCH] partial revert of overlays (+patch) |
Date: |
Mon, 13 Aug 2012 17:01:54 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) |
> OK, this is the partial revert: OV_xxx are dropped,
> buffer_set_overlays_(before|after) are used to set an appropriate
> pointers, and the rest is not touched (I suppose that unchain_both
> and buffer_has_overlays are OK).
Looks OK, thank you.
> - for (ov = buffer_get_overlays (b, OV_BEFORE); ov; ov = next)
> - {
> - drop_overlay (b, ov);
> - next = ov->next;
> - ov->next = NULL;
> - }
> -
> - for (ov = buffer_get_overlays (b, OV_AFTER); ov; ov = next)
> - {
> - drop_overlay (b, ov);
> - next = ov->next;
> - ov->next = NULL;
> - }
> -
> - buffer_set_overlays (b, NULL, OV_BEFORE);
> - buffer_set_overlays (b, NULL, OV_AFTER);
> + for (ov = b->overlays_before; ov; ov = next)
> + {
> + drop_overlay (b, ov);
> + next = ov->next;
> + ov->next = NULL;
> + }
> +
> + for (ov = b->overlays_after; ov; ov = next)
> + {
> + drop_overlay (b, ov);
> + next = ov->next;
> + ov->next = NULL;
> + }
> +
> + buffer_set_overlays_before (b, NULL);
> + buffer_set_overlays_after (b, NULL);
How did you get this hunk? Most of the lines seem 100% completely
totally unmodified and yet they appear as + and -.
Stefan