Broken build with --with-x-toolkit=no?

[Dmitry Antipov]

./configure --with-x-toolkit=no --enable-gcc-warnings 
--enable-check-lisp-object-type --enable-checking

=>

...
gcc -std=gnu99 -c   -isystem /usr/include/freetype2   -W -Wabi -Waddress -Wall -Warray-bounds -Wattributes -Wbad-function-cast -Wbuiltin-macro-redefined -Wcast-align -Wchar-subscripts -Wclobbered 
-Wcomment -Wcomments -Wcoverage-mismatch -Wcpp -Wdeprecated -Wdeprecated-declarations -Wdisabled-optimization -Wdiv-by-zero -Wdouble-promotion -Wempty-body -Wendif-labels -Wenum-compare -Wextra 
-Wformat-contains-nul -Wformat-extra-args -Wformat-security -Wformat-y2k -Wformat-zero-length -Wformat=2 -Wfree-nonheap-object -Wignored-qualifiers -Wimplicit -Wimplicit-function-declaration 
-Wimplicit-int -Winit-self -Wint-to-pointer-cast -Winvalid-memory-model -Winvalid-pch -Wmain -Wmaybe-uninitialized -Wmissing-braces -Wmissing-declarations -Wmissing-field-initializers 
-Wmissing-format-attribute -Wmissing-include-dirs -Wmissing-noreturn -Wmissing-parameter-type -Wmissing-prototypes -Wmudflap -Wmultichar -Wnarrowing -Wnonnull -Wnormalized=nfc -Wold-style-declaration 
-Wold-style-definition -Woverflow -Woverride-init -Wpacked -Wpacked-bitfield-compat -Wparentheses -Wpointer-arith -Wpointer-sign -Wpointer-to-int-cast -Wpragmas -Wreturn-type -Wsequence-point 
-Wstack-protector -Wstrict-aliasing -Wstrict-prototypes -Wsuggest-attribute=const -Wsuggest-attribute=noreturn -Wswitch -Wtrampolines -Wtrigraphs -Wtype-limits -Wuninitialized -Wunknown-pragmas 
-Wunused -Wunused-but-set-parameter -Wunused-but-set-variable -Wunused-function -Wunused-label -Wunused-local-typedefs -Wunused-macros -Wunused-parameter -Wunused-result -Wunused-value 
-Wunused-variable -Wvariadic-macros -Wvector-operation-performance -Wvolatile-register-var -Wwrite-strings -Wno-missing-field-initializers -Wno-sign-compare -Wno-type-limits -Wno-switch 
-Wno-unused-parameter -Wno-format-nonliteral -Wno-logical-op -fdiagnostics-show-option -funit-at-a-time -Werror   -g3 -O2 -DEMACS_BITMAP_FILES -I../src -I../lib 
-I/home/dima/work/stuff/emacs/trunk/oldXMenu -I/home/dima/work/stuff/emacs/trunk/oldXMenu/../src -I/home/dima/work/stuff/emacs/trunk/oldXMenu/../lib /home/dima/work/stuff/emacs/trunk/oldXMenu/DelPane.c
In file included from ../lib/stdio.h:58:0,
                 from /home/dima/work/stuff/emacs/trunk/oldXMenu/XMenuInt.h:23,
                 from /home/dima/work/stuff/emacs/trunk/oldXMenu/DelPane.c:16:
/usr/lib/gcc/x86_64-redhat-linux/4.7.2/include/stddef.h:150:1: error: expected 
‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘typedef’
In file included from /usr/include/X11/Xlib.h:44:0,
                 from /home/dima/work/stuff/emacs/trunk/oldXMenu/XMenuInt.h:24,
                 from /home/dima/work/stuff/emacs/trunk/oldXMenu/DelPane.c:16:
/usr/include/X11/X.h:66:1: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or 
‘__attribute__’ before ‘typedef’
/usr/include/X11/X.h:96:1: error: unknown type name ‘XID’
/usr/include/X11/X.h:97:1: error: unknown type name ‘XID’
/usr/include/X11/X.h:100:1: error: unknown type name ‘XID’
/usr/include/X11/X.h:102:1: error: unknown type name ‘XID’
/usr/include/X11/X.h:103:1: error: unknown type name ‘XID’
/usr/include/X11/X.h:104:1: error: unknown type name ‘XID’
/usr/include/X11/X.h:105:1: error: unknown type name ‘XID’
/usr/include/X11/X.h:106:1: error: unknown type name ‘XID’
In file included from 
/home/dima/work/stuff/emacs/trunk/oldXMenu/XMenuInt.h:24:0,
                 from /home/dima/work/stuff/emacs/trunk/oldXMenu/DelPane.c:16:
/usr/include/X11/Xlib.h:513:9: error: unknown type name ‘XID’
/usr/include/X11/Xlib.h:514:2: error: unknown type name ‘XID’
/usr/include/X11/Xlib.h:515:2: error: unknown type name ‘XID’
/usr/include/X11/Xlib.h:517:2: error: expected specifier-qualifier-list before 
‘XID’
/usr/include/X11/Xlib.h:935:2: error: unknown type name ‘XID’
/usr/include/X11/Xlib.h:1409:5: error: unknown type name ‘XID’
/usr/include/X11/Xlib.h:2788:5: error: unknown type name ‘XID’
/usr/include/X11/Xlib.h:3005:5: error: unknown type name ‘XID’
/usr/include/X11/Xlib.h:3016:5: error: unknown type name ‘XID’
In file included from 
/home/dima/work/stuff/emacs/trunk/oldXMenu/XMenuInt.h:25:0,
                 from /home/dima/work/stuff/emacs/trunk/oldXMenu/DelPane.c:16:
/home/dima/work/stuff/emacs/trunk/oldXMenu/X10.h:56:2: error: unknown type name 
‘XID’
/home/dima/work/stuff/emacs/trunk/oldXMenu/X10.h:75:54: error: unknown type 
name ‘XID’
In file included from /home/dima/work/stuff/emacs/trunk/oldXMenu/XMenu.h:20:0,
                 from /home/dima/work/stuff/emacs/trunk/oldXMenu/XMenuInt.h:26,
                 from /home/dima/work/stuff/emacs/trunk/oldXMenu/DelPane.c:16:
/usr/include/X11/Xutil.h:120:2: error: unknown type name ‘XID’
/usr/include/X11/Xutil.h:322:2: error: unknown type name ‘XID’
/usr/include/X11/Xutil.h:391:5: error: unknown type name ‘XID’
/usr/include/X11/Xutil.h:410:5: error: unknown type name ‘XID’
/usr/include/X11/Xutil.h:570:5: error: unknown type name ‘XID’
In file included from /home/dima/work/stuff/emacs/trunk/oldXMenu/DelPane.c:16:0:
/home/dima/work/stuff/emacs/trunk/oldXMenu/XMenuInt.h:63:53: error: unknown 
type name ‘XID’
/home/dima/work/stuff/emacs/trunk/oldXMenu/XMenuInt.h:65:51: error: unknown 
type name ‘XID’
/home/dima/work/stuff/emacs/trunk/oldXMenu/XMenuInt.h:66:53: error: unknown 
type name ‘XID’
/home/dima/work/stuff/emacs/trunk/oldXMenu/DelPane.c: In function 
‘XMenuDeletePane’:
/home/dima/work/stuff/emacs/trunk/oldXMenu/DelPane.c:37:5: error: implicit 
declaration of function ‘XDeleteAssoc’ [-Werror=implicit-function-declaration]
cc1: all warnings being treated as errors
make[2]: *** [DelPane.o] Error 1
make[2]: Leaving directory 
`/home/dima/work/stuff/emacs/trunk/build-no-toolkit/oldXMenu'
make[1]: *** [really-oldXMenu] Error 2
make[1]: Leaving directory 
`/home/dima/work/stuff/emacs/trunk/build-no-toolkit/src'
make: *** [src] Error 2

It looks like generated lib/stdio.h isn't good enough for oldXMenu :-(.

Dmitry