Re: [Emacs-diffs] /srv/bzr/emacs/trunk r111707: * doc-view.el: Use (and prefer) soffice as default ODF->PDF

[Glenn Morris]

Bastien wrote:

>> PS I think it's impossible to have unoconv without soffice, so this
>> change amounts to "always use soffice".
>
> I'm not sure I get the logic here: you need to have soffice installed
> if you want to use unoconv, but being able to use unoconv instead of
> soffice is good.  So as I understand it, the change does not amount
> to "always use soffice", does it?

(cond
   ((executable-find "soffice") "soffice")
   ((executable-find "unoconv") "unoconv")
   (t "soffice"))

It is impossible for this to return anything but "soffice".
IMO it should be:

(or (executable-find "unoconv") "soffice")