[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: cl-defstruct-based package.el, now with ert tests!
From: |
Dmitry Gutov |
Subject: |
Re: cl-defstruct-based package.el, now with ert tests! |
Date: |
Tue, 12 Mar 2013 16:03:05 +0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (windows-nt) |
Tom Tromey <address@hidden> writes:
> Daniel> The changes touch most of the code, but the overall structure of the
> Daniel> code has not changed significantly. Some parts of the code which were
> Daniel> questionable in the first place (such as using `tar-mode' to extract
> tar
> Daniel> archives) have been replaced with simpler alternatives. In the case of
> Daniel> tar, the file is simply downloaded to a temporary directory and
> Daniel> extracted using "tar xaf foo-1.2.3.tar".
>
> This sounds worse to me, since it means that now package installation
> has an external dependency. Previously this was not the case --
> intentionally.
Indeed, if that means that it won't work on vanilla Windows
installations, then this decision should be reversed.
The change looks good otherwise, I especially like the presence of tests.
- cl-defstruct-based package.el, now with ert tests!, Daniel Hackney, 2013/03/11
- Re: cl-defstruct-based package.el, now with ert tests!, Tom Tromey, 2013/03/11
- Re: cl-defstruct-based package.el, now with ert tests!,
Dmitry Gutov <=
- Re: cl-defstruct-based package.el, now with ert tests!, Ted Zlatanov, 2013/03/12
- Re: cl-defstruct-based package.el, now with ert tests!, Daniel Hackney, 2013/03/14
- Re: cl-defstruct-based package.el, now with ert tests!, Stephen J. Turnbull, 2013/03/14
- Re: cl-defstruct-based package.el, now with ert tests!, Ted Zlatanov, 2013/03/14
- Re: cl-defstruct-based package.el, now with ert tests!, Stefan Monnier, 2013/03/14
- Re: cl-defstruct-based package.el, now with ert tests!, chad, 2013/03/14
- Re: cl-defstruct-based package.el, now with ert tests!, Daniel Hackney, 2013/03/15
- Re: cl-defstruct-based package.el, now with ert tests!, Stefan Monnier, 2013/03/15
- Re: cl-defstruct-based package.el, now with ert tests!, Eli Zaretskii, 2013/03/15
- Re: cl-defstruct-based package.el, now with ert tests!, Ted Zlatanov, 2013/03/20