Re: /srv/bzr/emacs/trunk r112071: * lisp/whitespace.el: Fix double evaluation.

[Dmitry Gutov]

Stefan Monnier <address@hidden> writes:
> ------------------------------------------------------------
> revno: 112071
> committer: Stefan Monnier <address@hidden>
> branch nick: trunk
> timestamp: Sun 2013-03-17 21:50:32 -0400
> message:
>   * lisp/whitespace.el: Fix double evaluation.
>   (whitespace-space, whitespace-hspace, whitespace-tab)
>   (whitespace-newline, whitespace-trailing, whitespace-line)
>   (whitespace-space-before-tab, whitespace-indentation)
>   (whitespace-empty, whitespace-space-after-tab): Turn defcustoms into
>   obsolete defvars.

> -(defcustom whitespace-space 'whitespace-space
> +(defvar whitespace-space 'whitespace-space
>    "Symbol face used to visualize SPACE.
> -
> -Used when `whitespace-style' includes the value `spaces'."
> -  :type 'face
> -  :group 'whitespace)
> +Used when `whitespace-style' includes the value `spaces'.")
> +(make-obsolete-variable 'whitespace-space "use the face instead" "24.4")

> -     (list whitespace-space-regexp  1 whitespace-space  t)

> +     `(
> +       ,@(when (memq 'spaces whitespace-active-style)
> +           ;; Show SPACEs.
> +           `((,whitespace-space-regexp 1 whitespace-space t)

IIUC, this does not only make face vars obsolete, but also makes them have
no effect. Was that your intention?