emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: cl-defstruct-based package.el, now with ert tests and no external ta


From: Ted Zlatanov
Subject: Re: cl-defstruct-based package.el, now with ert tests and no external tar!
Date: Sat, 06 Apr 2013 17:02:09 -0400
User-agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.3.50 (gnu/linux)

On Fri, 5 Apr 2013 16:51:00 -0400 Daniel Hackney <address@hidden> wrote: 

DH> Dmitry Gutov <address@hidden> wrote:
>> It doesn't seem to apply cleanly to trunk, but here's the diff:
>> 
>> https://github.com/haxney/emacs/compare/3a5be1e2bf8b8b096f7c656c99f644b7dd0c4bab...package-rewrite.diff
>> 
>> It also has no ChangeLog entries (currently; the contents of the above
>> URL will update if/when Daniel adds them).

DH> I guess I'll have to rebase it off of trunk. Sorry about not giving a
DH> usable diff.

DH> I realized that I have a few things left to do for the patch:

DH>  - Create ChangeLog entries
DH>  - Update package-x.el. I haven't touched it and it is going to be
DH>    horribly broken.

DH> A question: should I submit this as a single large patch or break it
DH> up? It doesn't make much sense to have it broken up, since it is really
DH> an all-or-nothing overhaul, but if people want it broken up, I can
DH> certainly do so.

In the end it should be a single commit to the Bazaar repo, and there's
no reason to break it up for your audience here.

Ted




reply via email to

[Prev in Thread] Current Thread [Next in Thread]