emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: About commit style


From: Stefan Monnier
Subject: Re: About commit style
Date: Sun, 07 Apr 2013 11:48:47 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)

> * Reindent the file using the default indentation parameters.

No.  You can only fix local misindentation.

Any "bulk" cosmetic changes are annoying because they are sure to bump into
someone's local changes, creating spurious conflicts.

> * Change some code from putting close-parentheses on lines by themselves
>   to Lisp style.  (Although this almost never happened.)

Same here: doing it somewhere where you're already making other changes
is fine, but doing it systematically is not.

> * Change the comments to satisfy (info "(elisp) Comment Tips").

Idem.


        Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]