[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC] etags ada parser: doesn't stop when giving broken input
From: |
Stephen Leake |
Subject: |
Re: [RFC] etags ada parser: doesn't stop when giving broken input |
Date: |
Tue, 09 Apr 2013 05:00:58 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (windows-nt) |
Masatake YAMATO <address@hidden> writes:
> I expect etags stops even if broken input is given.
That's certainly reasonable
> I wrote a small patch. However, I'm not sure this is correct fix.
> Someone who knows both ada and etags, could you review this patch?
I know Ada, but not etags.
Your fix is not particular to Ada; it makes sense for any "token". It
looks reasonable to me, but I did not read the entire function (only the
patch).
Is there a test suite for etags.c? I could contribute some Ada code, if
needed.
--
-- Stephe