emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: MS-Windows build using Posix configury


From: Glenn Morris
Subject: Re: MS-Windows build using Posix configury
Date: Tue, 16 Apr 2013 20:42:54 -0400
User-agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/)

Eli Zaretskii wrote:

>         gnu-linux|freebsd|netbsd)
>           AC_DEFINE(HAVE_SOUND, 1, [Define to 1 if you have sound support.])
>           ;;
> +       mingw32)
> +         AC_DEFINE(HAVE_SOUND, 1, [Define to 1 if you have sound support.])
> +         ;;
[...]
> +if test "${opsys}" = "mingw32"; then
> +  AC_DEFINE(NULL_DEVICE, ["NUL:"], [Name of the file to open to get
> +    a null file, or a data sink.])
> +else
> +  AC_DEFINE(NULL_DEVICE, ["/dev/null"], [Name of the file to open to get
> +    a null file, or a data sink.])
> +fi
>  
> -AC_DEFINE(SEPCHAR, [':'], [Character that separates PATH elements.])
> +if test "${opsys}" = "mingw32"; then
> +  AC_DEFINE(SEPCHAR, [';'], [Character that separates PATH elements.])
> +else
> +  AC_DEFINE(SEPCHAR, [':'], [Character that separates PATH elements.])
> +fi

With things like this, I think it is better to have a single
unconditional AH_TEMPLATE that gives the doc string, then as many
AC_DEFINEs as needed that just set the value and don't duplicate the doc.
(There are probably other instances of this.)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]