emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Possible fix for crash in NS's tooltip showAtX:Y:for:


From: David Reitter
Subject: Possible fix for crash in NS's tooltip showAtX:Y:for:
Date: Mon, 29 Apr 2013 13:56:49 -0400

Suggest to initialize ns_tooltip as shown below.  I've been seeing occasional 
crash reports in Fx_show_tip (and showAtX).  This may be the culprit.  (I am 
not sure if variables in ObjC default to nil all the time.)
I don't have a working Bzr copy of Emacs, so apologies for posting this here.



commit 826f464359aae2461bcf4c8c986b5fb5242a9df7
Author: David Reitter <address@hidden>
Date:   Mon Apr 29 12:51:53 2013 -0400

    nsfns.m: initialize ns_tooltip to prevent crash
     nsfns.m (ns_tooltip): initialize.

diff --git a/src/ChangeLog b/src/ChangeLog
index 22a6cc2..7d6a620 100644
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,7 @@
+2013-04-29  David Reitter  <address@hidden>
+
+       * nsfns.m (ns_tooltip): initialize.
+
 2013-04-27  Juri Linkov  <address@hidden>
 
        * callint.c (Fcall_interactively): Call `Qread_number' for
diff --git a/src/nsfns.m b/src/nsfns.m
index a483f84..8049f4e 100644
--- a/src/nsfns.m
+++ b/src/nsfns.m
@@ -88,7 +88,7 @@ Lisp_Object Qfontsize;
 /* hack for OS X file panels */
 char panelOK = 0;
 
-EmacsTooltip *ns_tooltip;
+EmacsTooltip *ns_tooltip = nil;
 
 /* Need forward declaration here to preserve organizational integrity of file 
*/
 Lisp_Object Fx_open_connection (Lisp_Object, Lisp_Object, Lisp_Object);




reply via email to

[Prev in Thread] Current Thread [Next in Thread]