[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Possible fix for crash in NS's tooltip showAtX:Y:for:
From: |
Jan Djärv |
Subject: |
Re: Possible fix for crash in NS's tooltip showAtX:Y:for: |
Date: |
Thu, 2 May 2013 07:08:44 +0200 |
Hello.
2 maj 2013 kl. 06:53 skrev YAMAMOTO Mitsuharu <address@hidden>:
>>>>>> On Mon, 29 Apr 2013 13:56:49 -0400, David Reitter <address@hidden> said:
>
>> Suggest to initialize ns_tooltip as shown below. I've been seeing
>> occasional crash reports in Fx_show_tip (and showAtX). This may be
>> the culprit. (I am not sure if variables in ObjC default to nil all
>> the time.)
>
>> --- a/src/nsfns.m
>> +++ b/src/nsfns.m
>> @@ -88,7 +88,7 @@ Lisp_Object Qfontsize;
>> /* hack for OS X file panels */
>> char panelOK = 0;
>
>> -EmacsTooltip *ns_tooltip;
>> +EmacsTooltip *ns_tooltip = nil;
>
> Objective C is not different from the usual C in this respect (i.e.,
> implicit initialization of objects that have static storage duration).
> So the above change does not give any effect in theory, because `nil'
> is actually a null pointer.
>
ns_tooltip isn't static.
Jan D.