Re: fix for bug 10994 breaks ido customizations in major way

[Leo Liu]

On 2013-05-03 01:57 +0800, Le Wang wrote:
> bug:
> http://emacs.1067599.n5.nabble.com/bug-10994-23-3-ido-mode-ido-next-match-ido-prev-match-work-wrong-with-same-elements-td300.html
>
> The committed fix converts equal to eq, causing any plugin that propertizes
> the completion list to hang Emacs.
>
> This bug is filed as: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=14334
>
> The original bug report is essentially this:
>
> (ido-completing-read "dat is whrong -> " '("2" "3" "3" "3" "4" "5"))
>
> What's the expected behaviour in this case?  Shouldn't the duplicates from
> the list just be removed?

I put in the fix. It was based on how ido-matches are built from
ido-cur-list. So it fixes the bug.

I am not sure what new things you are doing with ido you will have to
look into this yourself..

Ideally ido should not modified the list fed to it. i.e.

(ido-completing-read "dat is whrong -> " '("2" "3" "3" "3" "4" "5"))

should be able to rotate for- band backwards without removing the dups.
It would be odd-looking if a user supply one list and ido display
another.

Cheers,
Leo