emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: fix for bug 10994 breaks ido customizations in major way


From: Le Wang
Subject: Re: fix for bug 10994 breaks ido customizations in major way
Date: Sat, 4 May 2013 21:00:15 +0800

On Sat, May 4, 2013 at 4:58 PM, Óscar Fuentes <address@hidden> wrote:
This change introduces a serious slowdown which is noticeable for large
candidate lists (try with 10000 elements.) The slowdown happens on every
invocation.

It is obvious that having duplicate candidates makes no sense, but at
the same time scanning the list in advance for all duplicates is
expensive.

The only way to introduce list with dupes is ido-completing-read (i.e. it's not an issue for files and buffers), so I think it's okay to remove dupes just once on entry.

Patch atached.


--
Le

Attachment: ido-remove-dups2.diff
Description: Binary data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]