Re: image-size

[Jan Djärv]

Hello.

21 jun 2013 kl. 08:15 skrev Eli Zaretskii <address@hidden>:

>> From: Jan Djärv <address@hidden>
>> Date: Thu, 20 Jun 2013 23:42:28 +0200
>> Cc: Eli Zaretskii <address@hidden>,
>> address@hidden
>> 
>> Loading the image just to determine the size is a huge overhead.  The image 
>> loading routines already know the image size before sending it to the server 
>> (or the equivalent for W32 and NS), otherwise they could not allocate the 
>> right size for the Pixmap.  No Imagemagic is needed to figure out the image 
>> size.
> 
> Yes.  Thus my suggestion to have a flag in the 'load' method that
> would cause it return right after computing the size.
> 

YAMAMOTO Mitsuharu <address@hidden> writes:

> Right.  And as I mentioned in (*), a possible way to solve this
> problem is to defer the creation of Pixmap (server side resource) from
> XImage (client side resource) until the actual display happens (i.e.,
> at prepare_image_for_display rather than lookup_image), so as to avoid
> unnecessary round trip of image data between the X11 server and
> client.

Only prepare_image_for_display have to set a different value for the suggested 
flag, as it does load if the image is not loaded yet.

        Jan D.