Re: [PATCHv4 1/4] `kill-buffer' runs query functions before checking buffer modification.

[martin rudalics]

>> We probably should guard against the case that the query functions
>> manage to kill the buffer prematurely.
>
> Except this would exactly defeat the purposes of this change.  Unless
> I don't understand what you mean by “prematurely”.  I'm assuming you
> want to prevent a function from doing:
>
>   (set-buffer-modified-p nil)
>   (let (kill-buffer-query-functions)
>     (kill-buffer (current-buffer)))
>
> or just that part without let.  But (set-buffer-modified-p nil) is
> exactly what remember-notes--kill-buffer-query wants to do (admittedly
> saving the contents prior).

Sure.  What I meant is that `kill-buffer' should return immediately when
the buffer is dead after calling the query functions instead of entering
the do_yes_or_no_p stuff with a dead buffer.  Or did I miss something?

martin