Re: cl-defstruct-based package.el, now with ert tests and no external tar!

[Daniel Hackney]

Dmitry Gutov <address@hidden> wrote:
> Just an update, I've tried to bring the tests over today, but they're quite
> dependent on the implementation.
>
> I still have 6/10 failures, so far.

That's odd. Make sure you remove "finder-inf.el{,c}" and re-make. Its
format has changed and it needs to be re-generated.

> Daniel:
>
> One thing I definitely didn't like is the usage of raw cl-struct vectors as
> reference values to compare against. These are implementation details of
> cl-defstruct, and we have no business setting them in stone in a test suite
> for code that just uses defstruct.

Good point. The raw vectors should be replaced with calls to
`package-desc-create' with the appropriate arguments.

> Relying on an external program (ginstall-info) is also not nice, for the
> usual alternative-OS-related reasons.

My rationale behind that was to have the multi-file package be in
"source form": all the files in the repo would be actual user-created
source files, and not generated files of any kind. That is probably
not necessary for testing, so the multi-file package directory could
be replaced with a single .tar. This means that all of the
package-building functions (and parts of `with-package-test') could be
removed as well.

-- 
Daniel Hackney