emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: cl-defstruct-based package.el, now with ert tests and no external ta


From: Dmitry Gutov
Subject: Re: cl-defstruct-based package.el, now with ert tests and no external tar!
Date: Thu, 27 Jun 2013 13:38:54 +0400
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7

I've checked in the tests, along with some tweaks and previously discussed simplifications. I've also taken the liberty to change the commentary, because the test suite hasn't eaten my package dir even once so far, and let-binding `package-alist' around the body of the big scary macro seems to make sure that the list of installed packages is also kept intact.

Thanks for your work, even though it hasn't been adopted in its entirety. If you feel strongly about some feature that hasn't been taken in, it should be easier to make a smaller, targeted patch now.

Comments and suggestions welcome, especially of the "why do the tests have to do that thing to make things work?" variety.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]