Re: trunk r113804: * decompress.c: Fix bugs with large buffers and weird inputs.

[Lars Magne Ingebrigtsen]

Paul Eggert <address@hidden> writes:

> Lars Magne Ingebrigtsen wrote:
>>  Does Emacs compile on any systems
>> where UINT_MAX is smaller than 16384?
>
> No, that code was just trying to remind the reader that
> the value cannot exceed UINT_MAX due to zlib constraints.
> I redid the code and comment a bit to try to make this clearer,
> in trunk bzr 113845.

I think writing 1 << 14 and then checking whether that's larger than
UINT_MAX is still pretty unclear.  My first thought, at least, was
"geez, he's making a HUGE buffer gap", until I started doing the math.

Please just write 16384 or something.  It's not like it's a magical
number.

-- 
(domestic pets only, the antidote for overdose, milk.)
  No Gnus T-Shirt for sale: http://ingebrigtsen.no/no.php
  and http://lars.ingebrigtsen.no/2013/08/twenty-years-of-september.html