Re: [Emacs-diffs] trunk r113888: * image.c (imagemagick_compute_animated_image): Implement animated images.

[Eli Zaretskii]

> Date: Thu, 15 Aug 2013 19:48:27 +0400
> From: Dmitry Antipov <address@hidden>
> Cc: Emacs development discussions <address@hidden>
> 
> /home/dima/work/stuff/emacs/trunk/src/image.c: In function 
> ‘imagemagick_compute_animated_image’:
> /home/dima/work/stuff/emacs/trunk/src/image.c:7913:5: error: pointer targets 
> in passing argument 2 of ‘PixelGetNextIteratorRow’ differ in signedness 
> [-Werror=pointer-sign]
>       while (source = PixelGetNextIteratorRow (source_iterator, 
> &source_width)) {
>       ^
> In file included from /usr/include/ImageMagick/wand/deprecate.h:29:0,
>                   from /usr/include/ImageMagick/wand/MagickWand.h:68,
>                   from /home/dima/work/stuff/emacs/trunk/src/image.c:7817:
> /usr/include/ImageMagick/wand/pixel-iterator.h:52:5: note: expected ‘size_t 
> *’ but argument is of type ‘long int *’
>     **PixelGetNextIteratorRow(PixelIterator *,size_t *),
>       ^
> /home/dima/work/stuff/emacs/trunk/src/image.c:7913:5: error: suggest 
> parentheses around assignment used as truth value [-Werror=parentheses]
>       while (source = PixelGetNextIteratorRow (source_iterator, 
> &source_width)) {
>       ^
> /home/dima/work/stuff/emacs/trunk/src/image.c:7914:7: error: pointer targets 
> in passing argument 2 of ‘PixelGetNextIteratorRow’ differ in signedness 
> [-Werror=pointer-sign]
>         dest = PixelGetNextIteratorRow (dest_iterator, &dest_width);
>         ^
> In file included from /usr/include/ImageMagick/wand/deprecate.h:29:0,
>                   from /usr/include/ImageMagick/wand/MagickWand.h:68,
>                   from /home/dima/work/stuff/emacs/trunk/src/image.c:7817:
> /usr/include/ImageMagick/wand/pixel-iterator.h:52:5: note: expected ‘size_t 
> *’ but argument is of type ‘long int *’
>     **PixelGetNextIteratorRow(PixelIterator *,size_t *),
>       ^
> cc1: all warnings being treated as errors
> 
> Could you please use an up-to-date compiler and --enable-gcc-warnings
> --enable-check-lisp-object-type --enable-checking for development?

These are BS warnings, IMO.  You will be better off disabling them
altogether.