Re: [Emacs-diffs] trunk r113896: Declare external variables.

[Stefan Monnier]

>>> +(eval-when-compile
>>> +  (defvar directory-sep-char)
>>> +  (defvar dired-move-to-filename-regexp))
>> You don't want to "eval" those defvars, since evaluating such a defvar is
>> mostly a no-op.  So don't put them inside eval-when-compile.
> But it doesn't hurt, does it?

Yes it does.  It actually hides those defvars from the compiler since it
passes the code to `eval' and only passes the result (aka nil) to the
compiler (at least, that's what "eval-when-compile" is supposed to
mean).

It's a bad habit.  The byte-compiler has to do extra work to find those
defvars because of people who write code like that.

Please fix it, so as not to set a bad example,


        Stefan