Re: trunk r114534: Get Ruby's SMIE code to pass the test suite.

[Dmitry Gutov]

Stefan Monnier <address@hidden> writes:

> It's only one test.

If you mean the example for Bug#15369, you're forgetting the
ruby-deep-indent-* examples, they can't all pass using the old engine,
with the same value of ruby-deep-indent-paren.

> old engine (not "default" any more).

Indeed.

>> automation. Do you intend to eventually remove it from
>> automated/ruby-mode-tests.el? I'd be firmly against that.
>
> Knowing that it's a sensitive issue, I just stay away from
> ruby-mode-tests.el.

Ok, thank you.

>> This one doesn't work for me. With SMIE, it indents like this:
>
>> MSG = 'Separate every 3 digits in the integer portion of a number' \
>>                                                                    'with 
>> underscores(_).'
>
> I installed a fix to smie.el at the same time.  The indentation you show
> is the one you get with the old smie.el.

Right, sorry. My smie.elc was stale.

Could you take a look at the examples I added in 114537 and 114538?

They're fairly characterisitc of real-life code (except the optional
"do", I guess).