Re: Input for TTY menus

[Darren Hoo]

On Fri, Oct 18, 2013 at 9:40 PM, Eli Zaretskii <address@hidden> wrote:

> What about my questions about the "Services" menu?  I don't think you
> answered those.

Thanks chad for explaining what  services menu for me.

Jan,

your  114716 commit totally removes the services menu. But I think some GUI 

users may use it, I sometimes use it while not quite often.

How about bring it back? I have tested the following patch on OSX, 

While I tried Emacs on GNUStep it crashes , but I don't think the crash is 

related to this.

I am curious that how many users use Emacs on GNUStep nowadays?

=== modified file 'lisp/menu-bar.el'

--- lisp/menu-bar.el 2013-10-19 08:35:51 +0000

+++ lisp/menu-bar.el 2013-10-19 18:14:38 +0000

@@ -45,16 +45,24 @@

     ;; The symbol used to be called `help', but that gets confused with the

     ;; help key.

     (setq menu-bar-final-items '(help-menu))

-  (if (eq system-type 'darwin)

-      (setq menu-bar-final-items '(buffer services help-menu))

-    (setq menu-bar-final-items '(buffer services hide-app quit))

-    ;; Add standard top-level items to GNUstep menu.

-    (bindings--define-key global-map [menu-bar quit]

-      '(menu-item "Quit" save-buffers-kill-emacs

-                   :help "Save unsaved buffers, then exit"))

-    (bindings--define-key global-map [menu-bar hide-app]

-      '(menu-item "Hide" ns-do-hide-emacs

-                  :help "Hide Emacs"))))

+  (if (eq window-system nil)

+      ;; No services menu in text-mode.

+      (if (eq system-type 'darwin)

+   (setq menu-bar-final-items '(buffer help-menu))

+ (setq menu-bar-final-items '(buffer hide-app quit)))

+    ;; We still want to use service menu in GUI.

+    (if (eq system-type 'darwin)

+ (setq menu-bar-final-items '(buffer services help-menu))

+      (setq menu-bar-final-items '(buffer services hide-app quit))

+      ;; Add standard top-level items to GNUstep menu.

+      (bindings--define-key global-map [menu-bar quit]

+ '(menu-item "Quit" save-buffers-kill-emacs

+     :help "Save unsaved buffers, then exit"))

+      (bindings--define-key global-map [menu-bar hide-app]

+ '(menu-item "Hide" ns-do-hide-emacs

+     :help "Hide Emacs")))

+    (bindings--define-key global-map [menu-bar services] ; Set-up in ns-win.

+      (cons "Services" (make-sparse-keymap "Services")))))

 

 ;; This definition is just to show what this looks like.

 ;; It gets modified in place when menu-bar-update-buffers is called.