Re: [PATCH 2/5] w32: add support for recent PNG library version >= 1.5

[Claudio Bley]

At Tue, 29 Oct 2013 18:50:52 +0200,
Eli Zaretskii wrote:
> 
> > Date: Tue, 29 Oct 2013 09:44:01 +0100
> > From: Claudio Bley <address@hidden>
> > Cc: address@hidden
> > 
> > At Sun, 27 Oct 2013 18:28:26 +0200,
> > Eli Zaretskii wrote:
> > > 
> > > Here, too, latest libpng versions are incompatible with 1.4.x, so we
> > > do need to make such a change.
> > > 
> > > However, when one builds libpng-X.Y.Z on Windows, the DLL that is
> > > installed is called libpngXY-XY.dll, not just libpngXY.dll, as your
> > > patch assumes.
> > 
> > I'm building with CMake and that's what the CMake builds produce.
> 
> Worth writing to the maintainers about, IMO, since CMake is not the
> standard build method (AFAIK).

On w32 it is probably more standard than building with autotools, IMO.

It also begs the question what the most reasonable name would be,
ie. what's the point of duplicating the version after a dash? Seems
it's only because of libtool, which is probably not really relevant on
w32 anyway.

> > If you download the release tarball (lpng166.7z) for win32, the DLL
> > produced is also called libpng16.dll.
> 
> If you build with CMake or if you build with the usual "configure && make"?

Neither, they support building with different compilers by copying a
Makefile from the "scripts" subdir to the project root dir. The w32
"tarballs" don't even have a configure script.