[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: OSX breakage for Emacs.app shortly after 10/17
From: |
Randal L. Schwartz |
Subject: |
Re: OSX breakage for Emacs.app shortly after 10/17 |
Date: |
Wed, 30 Oct 2013 17:17:31 -0700 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.2 (berkeley-unix) |
>>>>> "Randal" == Randal L Schwartz <address@hidden> writes:
Randal> Aha! There *is* a recent change in src/emacs.c applying to the
Randal> NS_IMPL_COCOA port. Perhaps this is the culprit:
Randal> if (!noninteractive)
Randal> {
Randal> #ifdef NS_IMPL_COCOA
Randal> - if (skip_args < argc)
Randal> + /* Started from GUI? */
Randal> + /* FIXME: Do the right thing if getenv returns NULL, or if
Randal> + chdir fails. */
Randal> + if (! inhibit_window_system && ! isatty (0))
Randal> + chdir (getenv ("HOME"));
Randal> + else if (skip_args < argc)
Randal> {
Randal> - /* FIXME: Do the right thing if getenv returns NULL, or if
Randal> - chdir fails. */
Randal> if (!strncmp (argv[skip_args], "-psn", 4))
Randal> {
Randal> skip_args += 1;
I'm convinced that "else if" should just be an "if". It needs to run
the lower code block even if the upper code block runs, or else the -psn
args are not processed. Any people smarter about Cocoa concur?
--
Randal L. Schwartz - Stonehenge Consulting Services, Inc. - +1 503 777 0095
<address@hidden> <URL:http://www.stonehenge.com/merlyn/>
Perl/Unix consulting, Technical writing, Comedy, etc. etc.
Still trying to think of something clever for the fourth line of this .sig