Re: OSX breakage for Emacs.app shortly after 10/17

[Jan Djärv]

Hello.

31 okt 2013 kl. 01:17 skrev Randal L. Schwartz <address@hidden>:

>>>>>> "Randal" == Randal L Schwartz <address@hidden> writes:
> 
> Randal> Aha! There *is* a recent change in src/emacs.c applying to the
> Randal> NS_IMPL_COCOA port.  Perhaps this is the culprit:
> 
> Randal>    if (!noninteractive)
> Randal>      {
> Randal>  #ifdef NS_IMPL_COCOA
> Randal> -      if (skip_args < argc)
> Randal> +      /* Started from GUI? */
> Randal> +      /* FIXME: Do the right thing if getenv returns NULL, or if
> Randal> +         chdir fails.  */
> Randal> +      if (! inhibit_window_system && ! isatty (0))
> Randal> +        chdir (getenv ("HOME"));
> Randal> +      else if (skip_args < argc)
> Randal>          {
> Randal> -         /* FIXME: Do the right thing if getenv returns NULL, or if
> Randal> -            chdir fails.  */
> Randal>            if (!strncmp (argv[skip_args], "-psn", 4))
> Randal>              {
> Randal>                skip_args += 1;
> 
> I'm convinced that "else if" should just be an "if".  It needs to run
> the lower code block even if the upper code block runs, or else the -psn
> args are not processed.  Any people smarter about Cocoa concur?

I don't know about smarter, but I was just doing that.  It took a while, 
Mavericks has upgraded svn to 1.7, which breaks bzr info, as it needs svn-lib 
from 1.6.  Mavericks does not pass -psn anymore BTW.

Fix checked in into trunk.

        Jan D.