Re: add keyword search and display in details for list-packages

[Ted Zlatanov]

On Mon, 25 Nov 2013 10:20:42 -0500 Stefan Monnier <address@hidden> wrote: 

>> I got `staging/packages/archive-contents' with the right contents for a
>> multi-file package (w3) but the single-file package keywords are not
>> getting generated.

SM> Good start, thanks.

>> I spent about 2 hours trying to figure out what's going on, following
>> your instructions (which worked) and debugging things ad-hoc.
>> It seems that the presence of the "PACKAGE-pkg.el" file is causing the
>> keyword evaluation to be skipped as a sort of cache takes over, but
>> I lost track of the indirection layers and couldn't figure it out.

SM> I can take a look.

>> If you could commit my patch and test it once, that would be great.

SM> I must have missed your patch.  Can you resend it?

It was earlier in this thread, re-attaching here.  Thanks for looking
into it!

Ted


diff --git a/admin/archive-contents.el b/admin/archive-contents.el
index 7ee9c1c..8fee66b 100644
--- a/admin/archive-contents.el
+++ b/admin/archive-contents.el
@@ -187,13 +187,18 @@ Otherwise, return nil."
                  (requires-str (lm-header "package-requires"))
                  (pt (lm-header "package-type"))
                  (simple (if pt (equal pt "simple") (= (length files) 1)))
+                 (keywords (split-string (or (lm-header "keywords") "")
+                                         "," t "[ ]+"))
                  (url (or (lm-header "url")
                           (format "http://elpa.gnu.org/packages/%s.html"; pkg)))
                  (req
                   (if requires-str
                       (mapcar 'archive--convert-require
                               (car (read-from-string requires-str))))))
-            (list simple version description req (list (cons :url url)))))))
+            (list simple version description req
+                  ;; extra parameters
+                  (list (cons :url url)
+                        (cons :keywords keywords)))))))
      ((not (file-exists-p pkg-file))
       (error "Can find single file nor package desc file in %s" dir)))))