Re: trunk r115265: * lisp/vc/vc-dispatcher.el (vc-log-edit): Setup the Summary&Author headers.

[Dmitry Gutov]

Stefan Monnier <address@hidden> writes:

> revno: 115265
>   * lisp/vc/vc-dispatcher.el (vc-log-edit): Setup the Summary&Author
> headers.

This looks like a fix of previously-implemented functionality, but I'm
not sure I like the result.

Pros: `log-edit-insert-changelog' and `log-edit-show-files' are nifty.

Cons:

1. The "Author" header will be almost always unused in other projects,
aside from Emacs, I'm contributing to. So it'll stick out like a sore
thumb. And even with Emacs, when the ChangeLog entry has the proper
author mentioned, it's auto-filled anyway.

2. The "Summary" doesn't add anything in the way of features, I can just
as well write it in the first line of the message.

When the buffer is displayed initially, the point is before "Summary:",
so now I have to move it first before I can write the commit message.

`vc-git-log-edit-toggle-amend' is not aware of this header and inserts
the whole message, summary and the rest, below the headers, leaving
"Summary" empty. Although this should be fixable.

3. If I decide I don't want to commit now, and I kill the log-edit
buffer (is there any other way to dismiss it?), the window and buffer
created by `log-edit-show-files', doesn't go anywhere, and I have to
take care of it separately. Also fixable.