emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC] Getting rid of selected_window


From: Stefan Monnier
Subject: Re: [RFC] Getting rid of selected_window
Date: Fri, 29 Nov 2013 09:38:35 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)

> I'm trying to get rid of selected_window, with an intent to completely
> cleanup corner cases where FRAME_SELECTED_WINDOW (selected_frame) is
> not the same as selected_window and avoid redundant synchronization of
> them.  Comments are welcome.

Indeed, I think that the two are now 100% synchronized, so we should be
able to get rid of `selected-window'.
A few comments, tho:
- Shouldn't we replace uses of `selected_window' with a call to an
  inlined function?  I.e. either make Fselected_window inlinable?
- If you want SELECTED_WINDOW (which should be an inlined function),
  then I think we should define it as XWINDOW (Fselected_window ())
  rather than providing a redundant definition.
- SELECTED_BUFFER should be a function rather than a macro and
  it should return a Lisp_Object rather than a struct buffer*.
  

        Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]