Re: trunk r115246: eww usability improvements

[Nakayama Kenjiro]

I found another tiny mistake in easy-menu. I resend the fixes.

Signed-off-by: Kenjiro NAKAYAMA <address@hidden>

        * net/eww.el (eww-mode-map): "Quit" in the easy-menu do a `quit-window' instead of killing the buffer. And fixed wrong function of "List bookmarks".

---
 lisp/net/eww.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 9d1c3a2..0c6513e 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -418,7 +418,7 @@ word(s) will be searched for via `eww-search-prefix'."

     (easy-menu-define nil map ""
       '("Eww"
-       ["Quit" eww-quit t]
+       ["Quit" quit-window t]
        ["Reload" eww-reload t]
        ["Back to previous page" eww-back-url
         :active (not (zerop (length eww-history)))]
@@ -429,7 +429,7 @@ word(s) will be searched for via `eww-search-prefix'."
        ["View page source" eww-view-source]
        ["Copy page URL" eww-copy-page-url t]
        ["Add bookmark" eww-add-bookmark t]
-       ["List bookmarks" eww-copy-page-url t]
+       ["List bookmarks" eww-list-bookmarks t]
        ["List cookies" url-cookie-list t]))
     map))

--
1.8.3.1

On Sun, Dec 8, 2013 at 11:40 AM, Nakayama Kenjiro <address@hidden> wrote:

> True.  I've now bound `q' to `quit-window'.

Then,  please apply this one, too.

Signed-off-by: Kenjiro NAKAYAMA <address@hidden>

        * net/eww.el (eww-mode-map): "Quit" in the easy-menu do a `quit-window'
        instead of killing the buffer.

---
 lisp/net/eww.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 9d1c3a2..1368912 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -418,7 +418,7 @@ word(s) will be searched for via `eww-search-prefix'."

     (easy-menu-define nil map ""
       '("Eww"
-       ["Quit" eww-quit t]
+       ["Quit" quit-window t]
        ["Reload" eww-reload t]
        ["Back to previous page" eww-back-url
         :active (not (zerop (length eww-history)))]
--
1.8.3.1

Kenjiro Nakayama

On Mon, Dec 2, 2013 at 2:00 AM, Lars Magne Ingebrigtsen <address@hidden> wrote:

"T.V. Raman" <address@hidden> writes:

> Would be far simpler to let 'q' bury-buffer -- gets it out of the
> way, and it's easy enough to jump back.

True.  I've now bound `q' to `quit-window'.

--
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no