Re: [Emacs-diffs] trunk r115886: Fix defun navigation in vc log view.

[Daniel Colascione]

On 01/06/2014 07:05 AM, Stefan Monnier wrote:
> > +       Fix defun navigation in vc log view.
> [...]
> >     (if (< arg 0)
> > +      (log-view-end-of-defun (- arg))
>
> This looks very fishy.  beginning-of-defun-function should never move to
> the end of a defun, even when called with a negative argument.

In the vc log case, the end of the defun is the beginning of the next, 
so in this case, the code should be correct.

> So, if this is really correct, it needs a comment explaining why this is
> the right thing to do.  And if you could add some regression tests for your
> commit it would be even better.

Sure.