[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: trunk r115926: In preparation for the move to git, sanitize out some
From: |
Juanma Barranquero |
Subject: |
Re: trunk r115926: In preparation for the move to git, sanitize out some Bazaar-specific names. |
Date: |
Thu, 9 Jan 2014 15:05:43 +0100 |
On Thu, Jan 9, 2014 at 2:47 PM, Eric S. Raymond <address@hidden> wrote:
> The more you talk about this, the less you're making any sense to me.
Same here.
> All this about the return value having structure is a red herring. You
> still *get* that structure by looking at emacs-bzr-version. I have
> not changed that and will not; only the VCS transition will do that.
Yes. And after the transition, code that depends on
emacs-release-version and emacs-release-get-version will get a string
with a different structure. With your current aliases, they will
continue existing, and they will return something different. That is
an incompatible change.
> With both the variable and function alias in place, I don't understand
> what code would need to be changed.
(and (bound-and-true-p emacs-bzr-version)
(- (read (emacs-bzr-get-version))
(read emacs-bzr-version)))
This fails right now because you didn't introduce an alias for
emacs-bzr-get-version. But, once that is fixed, it will still fail
after the switch because emacs-bzr(-get)-version won't return a string
containing a revno.
So the only compatible fix is to keep these, not as aliases, but as obsolete.
J
- Re: trunk r115926: In preparation for the move to git, sanitize out some Bazaar-specific names., (continued)
- Re: trunk r115926: In preparation for the move to git, sanitize out some Bazaar-specific names., Eric S. Raymond, 2014/01/08
- Re: trunk r115926: In preparation for the move to git, sanitize out some Bazaar-specific names., Juanma Barranquero, 2014/01/08
- Re: trunk r115926: In preparation for the move to git, sanitize out some Bazaar-specific names., Juanma Barranquero, 2014/01/08
- Re: trunk r115926: In preparation for the move to git, sanitize out some Bazaar-specific names., Eric S. Raymond, 2014/01/09
- Re: trunk r115926: In preparation for the move to git, sanitize out some Bazaar-specific names., Juanma Barranquero, 2014/01/09
- Re: trunk r115926: In preparation for the move to git, sanitize out some Bazaar-specific names., Eric S. Raymond, 2014/01/09
- Re: trunk r115926: In preparation for the move to git, sanitize out some Bazaar-specific names., Juanma Barranquero, 2014/01/09
- Re: trunk r115926: In preparation for the move to git, sanitize out some Bazaar-specific names., Eric S. Raymond, 2014/01/09
- Re: trunk r115926: In preparation for the move to git, sanitize out some Bazaar-specific names., Juanma Barranquero, 2014/01/09
- Re: trunk r115926: In preparation for the move to git, sanitize out some Bazaar-specific names., Eric S. Raymond, 2014/01/09
- Re: trunk r115926: In preparation for the move to git, sanitize out some Bazaar-specific names.,
Juanma Barranquero <=
- Re: trunk r115926: In preparation for the move to git, sanitize out some Bazaar-specific names., Eric S. Raymond, 2014/01/09
- Re: trunk r115926: In preparation for the move to git, sanitize out some Bazaar-specific names., Juanma Barranquero, 2014/01/09
- Re: trunk r115926: In preparation for the move to git, sanitize out some Bazaar-specific names., Eric S. Raymond, 2014/01/09
- Re: trunk r115926: In preparation for the move to git, sanitize out some Bazaar-specific names., Juanma Barranquero, 2014/01/09
- Re: trunk r115926: In preparation for the move to git, sanitize out some Bazaar-specific names., chad, 2014/01/09
- Re: trunk r115926: In preparation for the move to git, sanitize out some Bazaar-specific names., RĂ¼diger Sonderfeld, 2014/01/09
- Re: trunk r115926: In preparation for the move to git, sanitize out some Bazaar-specific names., Juanma Barranquero, 2014/01/09
- Re: trunk r115926: In preparation for the move to git, sanitize out some Bazaar-specific names., RĂ¼diger Sonderfeld, 2014/01/09
- Re: trunk r115926: In preparation for the move to git, sanitize out some Bazaar-specific names., Juanma Barranquero, 2014/01/09
- Re: trunk r115926: In preparation for the move to git, sanitize out some Bazaar-specific names., Juanma Barranquero, 2014/01/08