Re: Patches with independent changes

[Eli Zaretskii]

> Date: Sat, 25 Jan 2014 09:01:21 -0800
> From: Paul Eggert <address@hidden>
> Cc: address@hidden
> 
> --- update-game-score.c-old   2014-01-25 08:31:13.065305429 -0800
> +++ update-game-score.c       2014-01-25 08:31:54.337506871 -0800
> @@ -443,8 +443,13 @@
>    fd = mkostemp (tempfile, 0);
>    if (fd < 0)
>      return -1;
> +#ifdef WINDOWSNT
> +  if (chmod (tempfile, 0644) != 0)
> +    return -1;
> +#else
>    if (fchmod (fd, 0644) != 0)
>      return -1;
> +#endif
>    f = fdopen (fd, "w");
>    if (! f)
>      return -1;

This code is plain wrong: you cannot chmod a file that is open, if you
try, the chmod call will fail.

Again, I just restored the old code, but only for WINDOWSNT.  The
reason for that was that I wanted a safe change, since we are in a
feature freeze.  In any case, the fact that the problem could have
been solved in more than one way doesn't mean there are multiple
changes involved.