emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] trunk r116727: Revert last change to w32_read_socket.


From: Stefan Monnier
Subject: Re: [Emacs-diffs] trunk r116727: Revert last change to w32_read_socket.
Date: Mon, 10 Mar 2014 18:57:17 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)

>   Revert last change to w32_read_socket.

When reverting a change, always leave some trace about the reason for
the reversion.  E.g. add a comment, or at least a change-log message
pointing to the problem introduced by the code that justified the reversion.

If the reversion is because the original change was simply a pilot error
(never intended to commit it), then the change log should say so.  Else,
a comment in the code should explain the problem so that someone else
won't go through the same fruitless change.


        Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]