Re: Redisplay problems?

[Óscar Fuentes]

martin rudalics <address@hidden> writes:

>> I find a way to reproduce it reliably. Just run
>>
>> emacs -Q --eval "(progn (scroll-bar-mode -1) \
>>                         (iconify-or-deiconify-frame) \
>>                         (sleep-for 1))"
>>
>> Version (compiled from bzr):
>> GNU Emacs 24.3.50.7 (x86_64-unknown-linux-gnu, GTK+ Version 2.24.10) of 
>> 2014-03-18
>>
>> then deiconify the opened frame. The cursor is gone. The frame does not
>> redisplay correctly either.
>
> Does the attached patch fix it?  If so, we probably need a better way to avoid
>
>              If we where iconified, we should not set garbaged,
>              because that stops redrawing on Expose events.  This looks
>              bad if we are called from a recursive event loop
>              (x_dispatch_event), for example when a dialog is up.
>
> martin
> === modified file 'src/xterm.c'
> --- src/xterm.c       2014-03-11 06:50:01 +0000
> +++ src/xterm.c       2014-03-19 16:18:14 +0000
> @@ -6148,7 +6148,7 @@
>               because that stops redrawing on Expose events.  This looks
>               bad if we are called from a recursive event loop
>               (x_dispatch_event), for example when a dialog is up.  */
> -          if (!iconified)
> +/**           if (!iconified) **/
>              SET_FRAME_GARBAGED (f);
>
>            /* Check if fullscreen was specified before we where mapped the

Yes, the test case works correctly with that change.